FIX : Hidden dropdown download link in project #32102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldy
reviewed
Nov 27, 2024
| @@ -1288,7 +1288,7 @@ | |||
| print "</td>\n"; | |||
|
|
|||
| // Ref | |||
| print '<td class="left nowraponall tdoverflowmax250">'; | |||
| print '<td class="left nowraponall">'; | |||
There was a problem hiding this comment.
We need the tdoverflowmax250 for the case of object that do have a download arrwo and output a very long ref including a text (like loan , tasks).
The ref and is combo must alwyas be in a separated column so i suggest to split the td in 2. The first one with ref and link will be without the tdoverflow. The second that contains the very long text will have the tdoverflowmax250.
There was a problem hiding this comment.
I have put a table inside the td to prevent adding another td because the table head would not be right.
eldy
added
Discussion
|
@eldy Is it ok for you? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIX|Fix Hidden dropdown download link in project
I removed the tdoverflowmax class because it contains an "overflow: hidden;" that hide the dropdown of the download button and prevent access to menu when you want to download or preview the PDF.
Before :
Now:
